Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration script readme gives invalid order of arguments #2170

Open
1 task done
BeksOmega opened this issue Jan 26, 2024 · 2 comments
Open
1 task done

Migration script readme gives invalid order of arguments #2170

BeksOmega opened this issue Jan 26, 2024 · 2 comments
Assignees
Labels
size: small type: bug Something isn't working

Comments

@BeksOmega
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

@blockly/migrate

Description

The readme for the migration plugin suggests the following format for running the script:

npx @blockly/migrate rename --from 6 --in-place ./path/to/my/files*
npx @blockly/migrate rename --from 6 --to 7 --in-place ./path/to/my/files*

This is invalid because --in-place actually takes a file parameter (a suffix to add to the output). So this is running on no files.

It should look like:

npx @blockly/migrate rename ./path/to/my/files* --from 6 --in-place 
npx @blockly/migrate rename ./path/to/my/files* --from 6 --to 7 --in-place

The help options in the plugin may need to be updated as well. But fixing the readme is low lift.

Reproduction steps

Stack trace

No response

Screenshots

No response

@BeksOmega BeksOmega added type: bug Something isn't working triage labels Jan 26, 2024
@jenish-thapa
Copy link
Contributor

Hey @BeksOmega @maribethb,

I would like to work on this issue. Can you please assign this to me?

@BeksOmega
Copy link
Contributor Author

Go for it @jenish-thapa =) Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants