Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert theme plugins to ts #2158

Open
1 task done
tgbhy opened this issue Jan 18, 2024 · 1 comment
Open
1 task done

Convert theme plugins to ts #2158

tgbhy opened this issue Jan 18, 2024 · 1 comment
Labels
category: plugin Anything in the plugins folder type: feature request New feature or request

Comments

@tgbhy
Copy link

tgbhy commented Jan 18, 2024

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

Themes (like @blocky/theme-dark)

Description

There is no index.d.ts in module so we can't import it with Typescript (or we need to use //@ts-ignore)

Reproduction steps

  1. Prepare a typescript project
  2. Install the package named "@blockly/theme-dark"

Stack trace

[tsl] ERROR in C:\Users\user\Desktop\blocksk-typescript\src\index.ts(8,23)
      TS7016: Could not find a declaration file for module '@blockly/theme-dark'. 'C:\Users\esteb\Desktop\blocksk-typescript\node_modules\@blockly\theme-dark\dist\index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/blockly__theme-dark` if it exists or add a new declaration (.d.ts) file containing `declare module '@blockly/theme-dark';`

Screenshots

image

@tgbhy tgbhy added triage type: bug Something isn't working labels Jan 18, 2024
@maribethb maribethb changed the title module definition for themes (index.d.ts) Convert theme plugins to ts Jan 24, 2024
@maribethb
Copy link
Contributor

Hello, we've recently converted some of the plugins to TypeScript, but not all of them have been migrated. The themes should be pretty straightforward to migrate if you'd like to contribute a patch. You can copy a tsconfig out of any of the other plugins. Otherwise, this is in our backlog but we are not able to prioritize it in the coming quarter. Thanks!

@maribethb maribethb added type: feature request New feature or request category: plugin Anything in the plugins folder and removed type: bug Something isn't working triage labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: plugin Anything in the plugins folder type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants