Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated type hints - PEP 585 #361

Open
jeertmans opened this issue Sep 19, 2024 · 1 comment
Open

Use of deprecated type hints - PEP 585 #361

jeertmans opened this issue Sep 19, 2024 · 1 comment

Comments

@jeertmans
Copy link

Hello,

I am a frequent user of your library, but I also like to enforce good type hints, using type checkers like beartype.

However, when using types from your library, it appears that some of them use deprecated type hints from the built-in typing module, like typing.Iterator that has been moved to collections.abc.Iterator.

While this is not an issue at the moment (except that beartype complains about it, see https://beartype.readthedocs.io/en/latest/api_roar/#pep-585-deprecations), this will eventually become one when Python 3.14 will come out (in ~ 1 year I guess).

Could you consider updating the type hint to make your library future-compatible (at least to some extents)? Of course, I can help with this and make a PR.

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@jeertmans and others