Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of shebang in examples #1104

Open
approxit opened this issue Feb 23, 2023 · 0 comments
Open

Remove usage of shebang in examples #1104

approxit opened this issue Feb 23, 2023 · 0 comments

Comments

@approxit
Copy link
Contributor

approxit commented Feb 23, 2023

While working on #1086, my changes on windows machine implicitly changed file permissions for one of example python scripts. Goth tests are running on linux and are executing example code via:

$ ./example.py

which checks executable permission on file. Implicit switch from 755 to 644 dropped that permission, and test was failing.

We should not be prone to this kind of quirks, and there is no actual need to keep using shebangs. In fact using it expects python to be available in particular way, which may differ vastly from user to user.

Todo

  • Remove shebangs from all examples
  • Change example invocation on goth tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant