Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyze the vm.repo et al #1055

Open
shadeofblue opened this issue Nov 21, 2022 · 2 comments
Open

analyze the vm.repo et al #1055

shadeofblue opened this issue Nov 21, 2022 · 2 comments

Comments

@shadeofblue
Copy link
Collaborator

  • consider async/non-async
  • do we want to distinguish between image and image_hash in the function signature

related: #1044

@johny-b
Copy link
Contributor

johny-b commented Nov 21, 2022

Suggestion:

# This can create any payload, and is rarely used directly
payload = Payload(**kwargs)

# Creates VM payloads and uses internally Payload()
# (this is a non-async replacement for `vm.repo()`)
payload = Payload.vm(image_hash, **kwargs)

# Other functions might be implemented in the future
payload = Payload.whatever(any, args)

also related: #404

@cryptobench
Copy link
Member

#1044 now distinguishes between image_hash and image_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants