Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Node information in NetworkView #270

Open
nieznanysprawiciel opened this issue Jul 21, 2023 · 1 comment
Open

Clear Node information in NetworkView #270

nieznanysprawiciel opened this issue Jul 21, 2023 · 1 comment

Comments

@nieznanysprawiciel
Copy link
Contributor

Description:

  • We never clear Nodes information in NetworkView structure. Memory usage will grow after longer yagna uptime.
  • NetworkView in general should keep Node info as long as possible, because it serves the purpose of synchronization, when multiple Nodes are trying to initialize session with the same Node (but using many identities for example)
  • When session is closed, we can have other tasks/threads trying to initialize this session again, so the synchronization is still necessary.
  • NetworkView could be used to inform peers about Nodes that we know. So it could partially take over this responsibility from relay, when it is down

What:

  • Find proper policy of removing information from NetworkView
@staszek-krotki
Copy link
Contributor

This is done for sessions with servers, relayed connections are removed from the networkview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants