Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Nodes changing identities #256

Open
nieznanysprawiciel opened this issue Jun 30, 2023 · 0 comments
Open

Handle Nodes changing identities #256

nieznanysprawiciel opened this issue Jun 30, 2023 · 0 comments

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented Jun 30, 2023

Why:

  • We should make only one attempt to initialize session with other Node at the same time. But due to possibility of many identities, we can try to establish 2 session by mistake

In p2p network we never can have full knowledge about other Nodes and we must deal with this situation as good as possible.

Acceptance criteria:

  • Find and test different scenarios of problems with identities. Repair bugs if they will be found
  • Proposals of scenarios:
    • Node adding/removing identity
    • Node changing default identity
    • We get different information about Node from relay than later during initialization from Node directly
    • Node is connecting from different address than previously (this can happen if other Node is behind NAT and it connected to us directly)
    • Check initialization from different threads to the same Node using different identities
    • 2 Nodes are attempting to connect at the same time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant