Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silent on defer #1877

Open
danilobuerger opened this issue Oct 22, 2024 · 1 comment · May be fixed by #1879
Open

silent on defer #1877

danilobuerger opened this issue Oct 22, 2024 · 1 comment · May be fixed by #1879
Labels
state: needs triage Waiting to be triaged by a maintainer.

Comments

@danilobuerger
Copy link

Currently it doesn't seem possible to set silent on defers:

      - defer: echo "hello world"
        silent: true

      - defer:
          cmd: echo "hello world"
          silent: true

both dont work.
@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Oct 22, 2024
@trulede
Copy link

trulede commented Oct 23, 2024 •
edited
Loading

For a cmd, it seems that is not parsed from the YAML.

task/taskfile/ast/cmd.go

Line 82 in c4f708b

c.Cmd = deferredCmd.Defer

compare with line 68.

If you add "Silent bool" to "deferredCmd" and the necessary assignment (as per line 68) ... it might work.

Same again if you would use a defer task. Currently not parsed, but if you add it, might work. See line 91, here it is probably already parsed (its in type Call) but just not assigned.

@danilobuerger danilobuerger linked a pull request Oct 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: needs triage Waiting to be triaged by a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added silent for defer danilobuerger/task
3 participants
@danilobuerger @trulede @task-bot