Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Whispers under symlinks are not returned for queries (Grafana) with wildcards #806

Open
interfan7 opened this issue Nov 8, 2023 · 3 comments
Labels

Comments

@interfan7
Copy link

Describe the bug
For metrics in Whisper files which are under symlink (in the path):

  • Quering the metric specifically, e.g. x.y.z.w, is returned as expected.
  • Quering multiple metrics based on text-search, i.e. aliasByNode(x.[j]*y*.z.*.w, 1, 4), return only the metrics whose backing Whisper files are not under symlink.

It seems some searching functionality may malfunction when there is a symlink in the path of the Whispers.

CarbonAPI Version
0.16.0~1

Logs
Will update if I reproduce and find something which might be interesting.

CarbonAPI Configuration:
Basically we've barely modified the file versus the default version. We've focused on listening host:port. Will provide if necessary.

Simplified query (if applicable)
A general query template is in the description.

Backend metric retention and aggregation schemas
Will provide if needed, I believe it is not related to the nature of this issue.

Backend response (if possible)
Not sure what to fill-in here other than what is elaborated in description.
Our backend is go-carbon, the default behavior. We've not employed other solutions such as clickhouse.

Additional context
go-carbon 0.17.1.

@interfan7 interfan7 added the bug label Nov 8, 2023
@Civil
Copy link
Member

Civil commented Nov 8, 2023

On carbonapi level, there is no distinction between symlink or not anymore. I'd suspect that go-carbon returns weird results

@interfan7
Copy link
Author

On carbonapi level, there is no distinction between symlink or not anymore. I'd suspect that go-carbon returns weird results

Do you suggest me to create a new issue in go-carbon project?

(I'm not aware of GH having ability to port issue report to another project? Especially as each project has its own desired reporting format.)

@deniszh
Copy link
Member

deniszh commented Nov 8, 2023

Do you suggest me to create a new issue in go-carbon project?

I would say that make sense, especially because proper investigation would require some additional information, like, go-carbon config and exact symlink paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants