Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all files as viewed in Pull Request #32267

Open
TheBigNeo opened this issue Oct 15, 2024 · 2 comments
Open

Mark all files as viewed in Pull Request #32267

TheBigNeo opened this issue Oct 15, 2024 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@TheBigNeo
Copy link

Feature Description

Depending on the type of pull request, the effort required to mark each individual file as Viewed is very high.
For example, when files are moved in C#, only the using changes.

It would be nice to have a button that allows me to mark all files as Viewed at once.

Screenshots

image

@TheBigNeo TheBigNeo added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 15, 2024
@wxiaoguang
Copy link
Contributor

But why "mark all files as Viewed at once" would help? You could mark none and just approve it. The "viewed mark" is just an UI display, it affects nothing else.

@TheBigNeo
Copy link
Author

Example 1:

  • I create the PR
  • I check all MY files
  • Then I add a reviewer
  • He finds an error
  • I fix the error by making changes in 3 files
  • I check my files in the IDE and make a push
  • I open the PR

When I look at the PR again, I have to go to the commits to see my changes. However, if I had previously marked all files as Viewed , they would no longer be marked and I could check them again.

Example 2:

  • I am a reviewer
  • I check the files. As there are a lot of small changes, I have not set Viewed
  • I write comments
  • I give the task back to the developer, who makes changes and pushes them
  • I open the PR

I now have to go to the commits to see the changes.
But I have the disadvantage that I no longer see the whole context. If I had marked the files as Viewed, the changed files would no longer be Viewed and I could concentrate directly on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants