prevent comment on uploading #32263
prevent comment on uploading #32263
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
|
I found that the comment button here (in files changes tab) will not be checked (it will always be enabled), as what it does in conversation tab. Of cause, if you want, you can do it in another PR. Edited: |
|
@yp05327 |
| await uploadFile(dropzoneEl, file); // the "file" will get its "uuid" during the upload | ||
| dropzoneEl.dropzone.off('thumbnail', handleInsertPlaceholder); |
There was a problem hiding this comment.
It still doesn't seem right.
awaitmight fail and throw an exception, then the handler is left there.- If there are more than 1 files are being uploaded (in progress), then it will trigger more than one
handleInsertPlaceholdercalls, duplicate calls will insert duplicate placeholders ? For example, 2 files being uploaed, then 3 placeholders would be inserted?
There was a problem hiding this comment.
I corrected the first point, but I don't know how to solve the second problem. If you think of a way, can you suggest a solution?
There was a problem hiding this comment.
There is one more bad case: if a uploading fails, then there will be no onContentChanged callback, then the buttons stay "disabled".
I think the UI states should be managed by some well-defined events&handlers, but not by an ad-hoc "thumbnail" event with onContentChanged callback.
pull-request-size
bot
added
size/M
wxiaoguang
removed
type/bug
backport/v1.22
sangcheol12
force-pushed
the
fix/prevent-comment-on-uploading
branch
from
0a116c6
to
f3c7c26
Compare
|
I rewrote my code. Please review again. |
fix #32262
fix for new comment
fix for edit comment