allow comments on non-diff lines (#32257) #32259
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
Signed-off-by: abhishek818 <[email protected]>
abhishek818
force-pushed
the
comment_on_non_diff_lines
branch
from
350613c
to
a65f0f6
Compare
|
Once a user comments in the non-diff lines, it should be displayed in the changed files. So we need to automatically expand those lines that have non-diff comments. Or we can have a indicate icon there are comments hidden in non-diff code lines. |
|
IIRC, GitHub can only comment on those no displayed lines at first. I think this is for the concern mentioned above. So simply change the condition is not right I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32257
/claim #32257