Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Bindings #2

Open
mormj opened this issue Aug 10, 2021 · 1 comment
Open

Python Bindings #2

mormj opened this issue Aug 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mormj
Copy link
Contributor

mormj commented Aug 10, 2021

What does the PMT library look like in Python?

@mormj mormj added the enhancement New feature or request label Aug 10, 2021
@jsallay
Copy link
Collaborator

jsallay commented Aug 13, 2021

I have three thoughts on the matter.

  1. Since we are just wrapping flatbuffers, we don't need to wrap the c++ code. We can just write equivalent python wrappers for flatbuffers. I realize this means that we have additional independent code. However, I don't know how well pybind11 would work with things like iterators. I'm guessing that since pmts are approximating a python dictionary anyway that the wrapper code would be pretty simple.
  2. We should definitely include numpy support (i.e. convert to/from numpy arrays and pmts).
  3. We should make sure that when we pass a pmt from python to c++ or vice versa that it doesn't alloc new memory. We should be able to just pass pointers around.

mormj pushed a commit to mormj/pmt that referenced this issue Nov 17, 2022
More Vector considerations and serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants