Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-10-10: PMT Recursive Variants #2

Open
RalphSteinhagen opened this issue Oct 31, 2024 · 0 comments
Open

2024-10-10: PMT Recursive Variants #2

RalphSteinhagen opened this issue Oct 31, 2024 · 0 comments
Labels
GR4 Design GR 4 Architecture and Interface Design

Comments

@RalphSteinhagen
Copy link
Collaborator

  • 3 options
    -- recursive
    -- encapsulated unique ptr
    ---- like rust
    ---- gets rid of the recursion
    -- std::any

  • Tradeoffs
    -- runtime performance, syntax, LOCs in pmt

  • proof in the pudding
    -- recommended approach - try the std::any, wrap pmt::get and replace in gr4.0, pmt::visit
    -- see the qa_type_conversions test since it has ~75 combinations of blocks/pmts
    -- most of the changes in the settings, a few in block

  • Decision - make api that can swap under the hood these options if compilers advance in the future
    -- (also do the same for std::format vs fmt --> gr::fmt)

@RalphSteinhagen RalphSteinhagen added the GR4 Design GR 4 Architecture and Interface Design label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GR4 Design GR 4 Architecture and Interface Design
Projects
Development

No branches or pull requests

1 participant