Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking status of doctest passing on all Octave doc strings #188

Open
3 of 6 tasks
mtmiller opened this issue Jan 22, 2019 · 4 comments
Open
3 of 6 tasks

Tracking status of doctest passing on all Octave doc strings #188

mtmiller opened this issue Jan 22, 2019 · 4 comments

Comments

@mtmiller
Copy link
Collaborator

mtmiller commented Jan 22, 2019

It will be highly useful if all of Octave's core doc strings pass with doctest. Let's track the overall completion status of that goal here. That includes doctest issues that are blockers, Octave upstream issues preventing this, and lists of individual Octave doc strings that need to be worked on.

@cbm755
Copy link
Collaborator

cbm755 commented Jan 22, 2019

This issue seems as good as any, at least for high-level. I'll start editing a checklist into your first comment...

@mtmiller mtmiller changed the title track status of doctest on all Octave doc strings Tracking status of doctest passing on all Octave doc strings Jan 24, 2019
@cbm755
Copy link
Collaborator

cbm755 commented Mar 23, 2019

It might be good to try a release candidate for 0.7.0 on Octave just to make sure we haven't broken anything that would hinder this effort...

@mtmiller how do you actually do this? In the source tree after building?

make install
./run-octave
>> pkg install doctest-x.y.z+
>> doctest .

I get a lot of stuff like

/tmp/octave-help-OOYWOO:702: unknown command `DOCSTRING'
/tmp/octave-help-OOYWOO:704: unknown command `DOCSTRING'
/tmp/octave-help-OOYWOO:706: unknown command `DOCSTRING'
/tmp/octave-help-OOYWOO:708: unknown command `DOCSTRING'
/tmp/octave-help-OOYWOO:710: unknown command `DOCSTRING'

And maybe we shouldn't be testing both .txi and .texi? Just the .texi files which are autogenerated from .txi?

@mtmiller
Copy link
Collaborator Author

Yeah, I don't really remember how I did it before, but here's a way that works whether or not Octave is already installed, I think this gets pretty close to all documented functions. In the build tree

doctest ([__builtins__; 'libinterp/dldfcn'; '../scripts'])

or in a running installed Octave

doctest ([__builtins__; __octave_config_info__('octfiledir'); __octave_config_info__('fcnfiledir')])

@cbm755
Copy link
Collaborator

cbm755 commented Mar 23, 2019

Thanks! I tried the 0.7.0 RC with Octave 6.0.0 install,, checked out today:

  • __builtins__: hangs on popen2
  • __octave_config_info__('octfiledir'): FAIL 1/1
  • __octave_config_info__('fcnfiledir'): FAIL 74/214

With doctest-0.6.1:

  • __builtins__: hangs on popen2
  • __octave_config_info__('octfiledir'): N/A (not supported)
  • __octave_config_info__('fcnfiledir'): FAIL 73/214

So no significant differences between 0.6.1 and 0.7.0, which is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants