-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract route configuration into companion app #469
Comments
This was referenced Jan 7, 2025
This was referenced Jan 7, 2025
Merged
cristovaoth
pushed a commit
to gnosisguild/ser-kit
that referenced
this issue
Jan 9, 2025
…onment (#30) While working on gnosisguild/zodiac-pilot#469 I noticed that `ser-kit` relies on some node-specific modules. In this case, `assert`. While I know that there are ways of getting node modules into a browser bundle, I think for this specific case, using `@epic-web/invariant` instead of `assert` is also a good way forward. It eliminates the node dependency and makes `ser-kit` work more easily across environments. closes #20
This was referenced Jan 10, 2025
This was referenced Jan 16, 2025
frontendphil
changed the title
Extract route configuration into connect app
Extract route configuration into companion app
Jan 21, 2025
This was referenced Jan 21, 2025
frontendphil
added
product: extension
product: companion app
and removed
enhancement
labels
Jan 22, 2025
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, routes are configured inside the extension panel. This has some drawbacks:
Extracting the route configuration into a dedicated app can circumvent most of the issues mentioned above.
Todo
ser-kit
ready to be used also in browsers (feat: replace assert with invariant in code to not require node environment ser-kit#30)Related issues
The text was updated successfully, but these errors were encountered: