Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute right away for Safes with threshold 1 #375

Open
jfschwarz opened this issue Dec 16, 2024 · 0 comments
Open

Execute right away for Safes with threshold 1 #375

jfschwarz opened this issue Dec 16, 2024 · 0 comments

Comments

@jfschwarz
Copy link
Collaborator

If a Safe uses a threshold of 1 and I'm executing as an owner of the Safe, atm the transaction will only be signed and proposed via the transaction service. It should actually be directly executed in that case, though.

ser-kit actually already covers this logic but relies on the Safe waypoint's threshold field for that. We don't provide this field in our manually created routes.

We should get rid of the legacy connection migration functions and directly operate on the new routes model. This allows us to populate the threshold field once the user enters a Safe address and we fetch the Safe info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants