New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: token ordering disambiguation #69

Open

parseb opened this issue Nov 14, 2022 · 0 comments

parseb commented Nov 14, 2022

https://github.com/gnosis/zodiac-module-exit/blob/bed27304cc520538b63232b7c67f83685c2b5d01/packages/contracts/contracts/ExitModule/ExitERC20Module.sol#L64-L65

The @notice is false or ambiguous.
Statement does not revert if tokens[] is ordered lowest to highest. aka "not ordered highest to lowest".

https://github.com/gnosis/zodiac-module-exit/blob/bed27304cc520538b63232b7c67f83685c2b5d01/packages/contracts/contracts/ExitModule/ExitBase.sol#L35-L38
https://github.com/gnosis/zodiac-module-exit/blob/bed27304cc520538b63232b7c67f83685c2b5d01/packages/contracts/contracts/ExitModule/ExitBase.sol#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment