-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide example with actual GitHub release #5
Comments
Thanks for your feedback. I'm not sure if completely understand your workflow synchronisation requirement. If you have a better approach, we're very happy to accept PRs of course! |
Hey @erwin1, thanks for pointing me to the Scene Builder workflows, which are a good example. When you look at the GitHub releases such as the most recent v15.0.1, you will see that it "only" contains the default assets – which is the source code as zip and tar.gz. In contrast, my project's releases also contain the actual artifact. See, for example, v0.7.0. (It's currently only a jar file, but as mentioned earlier, I'm migrating to native images.) The point is, when using Gluon/GraalVM, the native image creation needs to run on three different OS. Once the corresponding native images have been created, they should be added to the GitHub release as assets. This, I guess, requires some sort of synchronization between the creation of the native images and the creation of the GitHub release. Scene Builder doesn't face this issue, because the bundle workflows only run on tagged commits and upload the result to S3. So, if you already have an example for the aforementioned workflow, please let me know. If not, and if you would find this helpful, I can open a PR as soon as I have wrapped my head around it. |
Do I understand it correctly you want one release' including the binaries for 3 different platforms? |
@erwin1 I decided to use a single workflow file with separate jobs, since synchronization between jobs is easier: First, there's an ordinary Maven build ( Workflow file: https://github.com/beatngu13/pdf-zoom-wizard/blob/develop/.github/workflows/build.yml Let me know if you want me to create a PR for your repo. Otherwise, feel free to close the issue. And thanks for your help! |
First of all: thanks a lot for the excellent documentation Gluon provides! 🙏
I'm currently migrating a JavaFX app from Java 8 / Oracle Java VM to Java 11 / GraalVM, particularly to provide native images. When it comes to GitHub Actions, I currently have two workflows:
v*
.)Since both workflows run on Linux and are independent from each other, this is not a big deal. Now, with native images for Linux, macOS and Windows, it gets a bit more complicated. What I'm thinking of at the moment:
I'm not 100 % sure, but I think this requires job/workflow synchronization -- if one doesn't want to put everything in one big workflow.
My question is: do you already have an example for this or something similar? If not, I'm happy to submit a PR once I have figured this out.
The text was updated successfully, but these errors were encountered: