Permit to authenticate to the HL API doc using the session cookie #18301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
approved these changes
Nov 13, 2024
|
As said in the failing test comment it should be rewriten: glpi/tests/functional/Glpi/Api/HL/Controller/CoreController.php Lines 329 to 331 in 484a265 I do not have time to do it right now, so I put back this PR status to draft |
cedric-anne
force-pushed
the
11.0/fix-hlapi-authentication
branch
from
5181046 to
962707c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Instead of using the
remember_mecookie, I p^ropose to use directly the session cookie for the HL API doc authentication. It fixes #18299.