Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typings on all components #388

Open
franciscrispin opened this issue Jun 25, 2020 · 0 comments
Open

Improve typings on all components #388

franciscrispin opened this issue Jun 25, 2020 · 0 comments

Comments

@franciscrispin
Copy link
Contributor

Each component should extend the props of it's own native element e.g. for Button

interface Props extends React.HTMLProps<HTMLButtonElement> {
  ...
}

Will have to figure out a way to to make the typings work when the Button is used as an anchor too though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franciscrispin