Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@glimmer/syntax 0.92.1 release issues #1621

Closed
davidtaylorhq opened this issue Sep 12, 2024 · 3 comments
Closed

@glimmer/syntax 0.92.1 release issues #1621

davidtaylorhq opened this issue Sep 12, 2024 · 3 comments

Comments

@davidtaylorhq
Copy link

davidtaylorhq commented Sep 12, 2024

We're seeing lots of failures when updating from @glimmer/syntax 0.92.0 to 0.92.1:

e.g. with eslint:

Error: Failed to load parser 'ember-eslint-parser' declared in '.eslintrc.cjs#overrides[0]': Cannot find module '/__w/discourse/discourse/node_modules/.pnpm/[email protected]_@[email protected]_eslint@[8](https://github.com/discourse/discourse/actions/runs/10837079714/job/30072252018?pr=28885#step:11:9).57.0/node_modules/@glimmer/syntax/dist/dev/index.cjs'
...

Embroider build:

[BABEL] /__w/discourse/discourse/app/assets/javascripts/discourse/node_modules/.embroider/rewritten-app/assets/discourse.js/discourse.js: Cannot find module '/__w/discourse/discourse/app/assets/javascripts/discourse-widget-hbs/node_modules/@glimmer/syntax/dist/dev/index.cjs' (While processing: "/__w/discourse/discourse/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@embroider/core/src/portable-babel-launcher.js")

and more. PR here: discourse/discourse#28885

Looking at the npm code browser, it seems like the dist/ directory is missing from the released package?

@davidtaylorhq
Copy link
Author

davidtaylorhq commented Sep 12, 2024

I guess this is fixed by 1d935c9, but a release of @glimmer/syntax needs to be triggered 🤔

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Sep 12, 2024

yea, I need to sync with @mansona on some release-plan stuff (or get some focus time to debug).

I need to trigger a re-release of all the packages, because I forgot to add the build step when switching over to release-plan.

You make a good point that since @glimmer/syntax is used outside our ecosystem (in astexplorer, prettier, etc) -- I should get this fixed as asap-ily as possible

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Sep 13, 2024

0.92.3 is out

image

aaaand, the ember upgrade PR is green: emberjs/ember.js#20746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants