From 0fde5c8e02e846d2c0193197c100a27a988635bf Mon Sep 17 00:00:00 2001
From: Yehuda Katz <wycats@gmail.com>
Date: Wed, 13 Nov 2024 20:39:47 -0700
Subject: [PATCH] Fix lints

---
 .vscode/settings.json                         | 21 +++++--------------
 .../test/chaos-rehydration-test.ts            |  2 --
 packages/@glimmer/debug/lib/dism/opcode.ts    |  4 ++--
 packages/@glimmer/interfaces/tsconfig.json    |  9 ++------
 .../syntax/test/legacy-interop-test.ts        |  1 -
 .../@glimmer/syntax/test/plugin-node-test.ts  |  1 -
 6 files changed, 9 insertions(+), 29 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index dd28b1ac36..6004717a8a 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -28,18 +28,13 @@
       "mode": "auto"
     }
   ],
-  "eslint.validate": [
-    "javascript",
-    "typescript",
-    "json",
-    "jsonc"
-  ],
+  "eslint.validate": ["javascript", "typescript", "json", "jsonc"],
   "files.exclude": {
     "**/.DS_Store": true,
     "**/.git": true,
     "**/node_modules": true,
     "**/dist": true,
-    "tracerbench-results": true,
+    "tracerbench-results": true
   },
   "files.insertFinalNewline": true,
   "files.trimTrailingWhitespace": true,
@@ -60,15 +55,9 @@
   "eslint.problems.shortenToSingleLine": true,
   "typescript.experimental.expandableHover": true,
   "inline-bookmarks.expert.custom.words.mapping": {
-    "warn": [
-      "@premerge(\\s|$)"
-    ],
-    "active": [
-      "@active(\\s|$)"
-    ],
-    "fixme": [
-      "@fixme(\\s|$)"
-    ]
+    "warn": ["@premerge(\\s|$)"],
+    "active": ["@active(\\s|$)"],
+    "fixme": ["@fixme(\\s|$)"]
   },
   "inline-bookmarks.expert.custom.styles": {
     "active": {
diff --git a/packages/@glimmer-workspace/integration-tests/test/chaos-rehydration-test.ts b/packages/@glimmer-workspace/integration-tests/test/chaos-rehydration-test.ts
index a1df39e578..a036d41de9 100644
--- a/packages/@glimmer-workspace/integration-tests/test/chaos-rehydration-test.ts
+++ b/packages/@glimmer-workspace/integration-tests/test/chaos-rehydration-test.ts
@@ -90,12 +90,10 @@ abstract class AbstractChaosMonkeyTest extends RenderTest {
 
     let removedNodeDisplay: Nullable<string>;
     switch (nodeToRemove.nodeType) {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       case COMMENT_NODE:
         removedNodeDisplay = `<!--${nodeToRemove.nodeValue}-->`;
         break;
 
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       case ELEMENT_NODE:
         removedNodeDisplay = castToBrowser(nodeToRemove, ['HTML', 'SVG']).outerHTML;
         break;
diff --git a/packages/@glimmer/debug/lib/dism/opcode.ts b/packages/@glimmer/debug/lib/dism/opcode.ts
index 520499594a..caf0222c47 100644
--- a/packages/@glimmer/debug/lib/dism/opcode.ts
+++ b/packages/@glimmer/debug/lib/dism/opcode.ts
@@ -165,13 +165,13 @@ export function debugValue(item: unknown, options?: ValueRefOptions): Fragment {
   if (isIndexable(item)) {
     const classified = getLocalDebugType(item)!;
 
-    if (classified) return describeValue(classified, options);
+    if (classified) return describeValue(classified);
   }
 
   return unknownValue(item, options);
 }
 
-function describeValue(classified: ClassifiedLocalDebug, options?: ValueRefOptions): Fragment {
+function describeValue(classified: ClassifiedLocalDebug): Fragment {
   switch (classified.type) {
     case 'args':
       return describeArgs(classified.value);
diff --git a/packages/@glimmer/interfaces/tsconfig.json b/packages/@glimmer/interfaces/tsconfig.json
index d6b3ef9a7a..db6fab863e 100644
--- a/packages/@glimmer/interfaces/tsconfig.json
+++ b/packages/@glimmer/interfaces/tsconfig.json
@@ -1,13 +1,8 @@
 {
-  "extends": [
-    "../tsconfig.json"
-  ],
+  "extends": ["../tsconfig.json"],
   "compilerOptions": {
     "rootDir": ".",
     "moduleResolution": "bundler"
   },
-  "include": [
-    "index.d.ts",
-    "lib"
-  ]
+  "include": ["index.d.ts", "lib"]
 }
diff --git a/packages/@glimmer/syntax/test/legacy-interop-test.ts b/packages/@glimmer/syntax/test/legacy-interop-test.ts
index 7aaa379f20..367f8a3948 100644
--- a/packages/@glimmer/syntax/test/legacy-interop-test.ts
+++ b/packages/@glimmer/syntax/test/legacy-interop-test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable deprecation/deprecation */
 import { builders as b } from '@glimmer/syntax';
 
 QUnit.module('[glimmer-syntax] AST nodes legacy interop');
diff --git a/packages/@glimmer/syntax/test/plugin-node-test.ts b/packages/@glimmer/syntax/test/plugin-node-test.ts
index aef0750244..ddf73bad6e 100644
--- a/packages/@glimmer/syntax/test/plugin-node-test.ts
+++ b/packages/@glimmer/syntax/test/plugin-node-test.ts
@@ -48,7 +48,6 @@ test('deprecated program visitor', (assert) => {
     return {
       name: 'plugin',
       visitor: {
-        // eslint-disable-next-line deprecation/deprecation
         Program(node: AST.Program) {
           assert.step(node.type);
         },