Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n-tasks missing does not respect explicitly defined locales #588

Open
jaredmoody opened this issue Jun 20, 2024 · 2 comments
Open

i18n-tasks missing does not respect explicitly defined locales #588

jaredmoody opened this issue Jun 20, 2024 · 2 comments
Labels

Comments

@jaredmoody
Copy link
Contributor

When locales are set in the config, I'd expect only missing keys in those locales to be included when i18n-tasks missing is run.

Instead, any missing keys in any locales defined in my data.read path is returned, and to get the result I want, I have to run: i18n-tasks missing -l, passing in all of the locales again.

This seems like a bug to me, but I want to confirm before I submit a PR.

Thanks!

@jaredmoody jaredmoody changed the title Missing does not respect explicitly defined locales i18n-tasks missing does not respect explicitly defined locales Jun 20, 2024
@davidwessman
Copy link
Collaborator

I'll leave this decision to @glebm

@glebm
Copy link
Owner

glebm commented Jun 23, 2024

Yeah, sounds like a bug. Data should be filtered if the locales are configured explicitly. PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants