From 5a9a940442afe86d7a2db4bfd2f03788d7b2c957 Mon Sep 17 00:00:00 2001 From: Louis Pilfold Date: Tue, 3 Dec 2024 16:12:42 +0000 Subject: [PATCH] Clippy --- .../src/language_server/tests/completion.rs | 4 ++-- compiler-core/src/type_/tests.rs | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/compiler-core/src/language_server/tests/completion.rs b/compiler-core/src/language_server/tests/completion.rs index d120ecd3d8d..b5d3a63da62 100644 --- a/compiler-core/src/language_server/tests/completion.rs +++ b/compiler-core/src/language_server/tests/completion.rs @@ -25,8 +25,8 @@ pub fn show_complete(code: &str, position: Position) -> String { fn apply_conversion(src: &str, completions: Vec, value: &str) -> String { let completion = completions .iter() - .find(|c| c.label == value.to_string()) - .expect(&format!("no completion with value `{value}`")); + .find(|c| c.label == *value) + .unwrap_or_else(|| panic!("no completion with value `{value}`")); let mut edits = vec![]; if let Some(lsp_types::CompletionTextEdit::Edit(edit)) = &completion.text_edit { diff --git a/compiler-core/src/type_/tests.rs b/compiler-core/src/type_/tests.rs index 966253bec12..33423852ada 100644 --- a/compiler-core/src/type_/tests.rs +++ b/compiler-core/src/type_/tests.rs @@ -256,7 +256,7 @@ macro_rules! assert_warnings_with_imports { vec![ $(("thepackage", $name, $module_src)),* ], - crate::build::Target::Erlang, + $crate::build::Target::Erlang, None ); @@ -272,7 +272,7 @@ macro_rules! assert_warnings_with_imports { #[macro_export] macro_rules! assert_warning { ($src:expr) => { - let warning = $crate::type_::tests::get_printed_warnings($src, vec![], crate::build::Target::Erlang, None); + let warning = $crate::type_::tests::get_printed_warnings($src, vec![], $crate::build::Target::Erlang, None); assert!(!warning.is_empty()); let output = format!("----- SOURCE CODE\n{}\n\n----- WARNING\n{}", $src, warning); insta::assert_snapshot!(insta::internals::AutoName, output, $src); @@ -309,7 +309,7 @@ macro_rules! assert_js_warning { let warning = $crate::type_::tests::get_printed_warnings( $src, vec![], - crate::build::Target::JavaScript, + $crate::build::Target::JavaScript, None, ); assert!(!warning.is_empty()); @@ -324,7 +324,7 @@ macro_rules! assert_js_no_warnings { let warning = $crate::type_::tests::get_printed_warnings( $src, vec![], - crate::build::Target::JavaScript, + $crate::build::Target::JavaScript, None, ); assert!(warning.is_empty()); @@ -337,7 +337,7 @@ macro_rules! assert_warnings_with_gleam_version { let warning = $crate::type_::tests::get_printed_warnings( $src, vec![], - crate::build::Target::Erlang, + $crate::build::Target::Erlang, Some($gleam_version), ); assert!(!warning.is_empty()); @@ -349,7 +349,7 @@ macro_rules! assert_warnings_with_gleam_version { #[macro_export] macro_rules! assert_no_warnings { ($src:expr $(,)?) => { - let warnings = $crate::type_::tests::get_warnings($src, vec![], crate::build::Target::Erlang, None); + let warnings = $crate::type_::tests::get_warnings($src, vec![], $crate::build::Target::Erlang, None); assert_eq!(warnings, vec![]); }; ($(($package:expr, $name:expr, $module_src:literal)),+, $src:expr $(,)?) => {