-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce and upload HTML artifacts of the notebook runs #365
Comments
We spent quite a lot of effort originally to not have the notebooks render on RTD, since that was unbearably slow. What I meant was simply to replace
with
and then upload the resulting HTML files with the GitHub action. |
The uploading HTML part is not very clear to me. Do you mean automatically committing the generated HTML output and pushing it to the GLASS repository? But that will not show up on readthedocs. I don't think there is a way to push to readthedocs? |
I just meant - uses: actions/upload-artifact@v4
with:
path: examples/*.html so we can check the outputs from the test run if necessary (since we are recomputing the examples anyway). |
In the future, we could a) recompute the example notebooks in place, and fail the test if the outputs change, and b) have an automated way to recompute the examples. But neither is relevant right now for what we need to do. |
Ahh, now I understand it better, thanks! |
Add your issue here
Originally posted by @ntessore in #345 (comment)
I think it would be better to get rid off the "Test examples" session and just run them on readthedocs, given that one has to pre-run the notebooks in order for them to show up with good outputs on readthedocs.
The text was updated successfully, but these errors were encountered: