generated from CodeYourFuture/cyf-final-project-starter-kit
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB/1 Store suggested sentences as separate entries with separate ids (all corresponding to the same sentence id) #27
Comments
4 tasks
AppolinFotso
moved this from 🏗 In progress
to 👀 In review
in Gaelic Project Planner Board
Oct 11, 2023
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Gaelic Project Planner Board
Oct 12, 2023
While there are some issues with this PR I will commit it as it includes a couple important architectural changes that should be in main. The ticket should be kept open to fix a couple remaining issues as a new PR:
|
AppolinFotso
moved this from 🏗 In progress
to 👀 In review
in Gaelic Project Planner Board
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, all suggested sentences are under one id. In JSON file, they appear as just one entry, comma-spearated. This is not ideal for further data processing.
We want to store the suggested sentences as separate entries (a sentence per JSON line) with separate ids.
The text was updated successfully, but these errors were encountered: