-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework build #6
Comments
Any preferred storage method? |
No, it's just that I wrote in the README:
If someone wants to use something else, they shouldn't need the SQLite dependency. Since the fuctions in libomemo,c do not depend on storage functions, this should just be an additional makefile target. I just have to remember to do it. |
Would you be open (I think it came up in another MR) to using a different build system? I raise this point because I came across an issue with crosscompiling to aarch64
This is an excerpt from a debian build for arm64 packages (used f.e. on the pinephone or Librem5) http://crossqa.debian.net/build/libomemo_0.7.0-1_arm64_20210501231231.log It has been pointed out to me that doing If we were to switch to meson f.e. that could solve such problems automatically :) If you feel this should be a different issue (because this one has an emphasis on the storage/sqlite question) I can file a new one! |
Please note that |
hi @fortysixandtwo! according to |
I added this at the time when I was packaging it for Debian and wanted the libraries to be installed to /usr/lib/x86_64-linux-gnu (in the case for amd64) I actually wasn't aware of the crossbuilding issue at the time |
If anyone interested, see rationale: |
The crossbuild issue is fixed by #36 |
FWIW, meson has support for building cmake-based subprojects, so while you might end up having two build systems installed, you may not actually be interacting with anything other than meson. Also, meson has https://wrapdb.mesonbuild.com/ which collects meson ports for various projects (that often do not already use meson), which are then available for any project to use. It is probably not very hard to port that one. You'd then go back down to one build system. :) I am obviously extremely biased, but I do think meson is much easier to learn/configure, and it is particularly nice that meson can do dependency lookups which seamlessly support both finding system dependencies and finding subprojects, and allows the person building the software to choose which one is preferred. Adding subproject fallbacks for a dependency doesn't even require modifying the build system :) just adding a small ini file to the subprojects/ directory. |
CMake build system + msys2 windows binaries CI (fixes #6)
The text was updated successfully, but these errors were encountered: