-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add short.io as a shortening link #544
Comments
Thank you. The issue was created to let members practice their programming skills. |
Hey @nevo-david, can I work in this feature ? All I need to create a new file as short.io.ts that implements ShortLinking interface and implement all the methods from ShortLinking, so we can talk with short.io apis. Finally, I need to import the new class inside ShortLinking service, so we can use it. Let me know you thoughts and guide me if I am missing something and please assign this issue to me, as I have started in this issue. |
Yes, it's very simple :) |
sure, thanks :) |
Hey @nevo-david , I was going through the docs of short.io and exploring the apis that will be needed for this integration. What should be the value of this domain ? |
@ak7550 I think we can use their short.io domain if we want, we don't have to use a customized one |
Hi @nevo-david, quick update, I have implemented the necessary changes, that you can check the pr #564 . Would you like to share that how do you debug your code ? This is the first time I am working with nx, so it's a bit overwhelming for me to figure out the debug configuration for nx. So this is the only thing due to which my progress is kind of blocked. I will keep on updating my work status in this thread. |
Hey @nevo-david this feature is ready, please give a quick check and let me know if it needs any changes. #564 |
🔖 Feature description
We have implemented a shortening link option,
It automatically shortens every link in the post.
It's pretty simple to add providers.
🎤 Why is this feature needed ?
We want to use their favorite shortening linking program!
✌️ How do you aim to achieve this?
It's pretty simple,
🔄️ Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?
Are you willing to submit PR?
None
The text was updated successfully, but these errors were encountered: