Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add short.io as a shortening link #544

Open
1 task done
nevo-david opened this issue Jan 12, 2025 · 8 comments · May be fixed by #564
Open
1 task done

Feature: Add short.io as a shortening link #544

nevo-david opened this issue Jan 12, 2025 · 8 comments · May be fixed by #564
Assignees
Labels
good first issue Good for newcomers type: feature-request New feature or request

Comments

@nevo-david
Copy link
Contributor

🔖 Feature description

We have implemented a shortening link option,
It automatically shortens every link in the post.
It's pretty simple to add providers.

🎤 Why is this feature needed ?

We want to use their favorite shortening linking program!

✌️ How do you aim to achieve this?

It's pretty simple,

  • Go to libraries/nestjs-libraries/src/short-linking/providers
  • Duplicate dub.ts and rename it to short.io.ts
  • Implement all the logic of ShortLinking interface.
  • Go to libraries/nestjs-libraries/src/short-linking/short.link.service.ts and add the new provider to getProvider function.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@nevo-david nevo-david added type: feature-request New feature or request good first issue Good for newcomers labels Jan 12, 2025
@nevo-david
Copy link
Contributor Author

Thank you. The issue was created to let members practice their programming skills.
We are not looking for AI solutions at the moment.

@gitroomhq gitroomhq deleted a comment Jan 12, 2025
@gitroomhq gitroomhq deleted a comment from iaskgithub Jan 13, 2025
@ak7550
Copy link

ak7550 commented Jan 19, 2025

Hey @nevo-david, can I work in this feature ?
Apparently, it looks pretty simple, let me know if my understandings are correct..
So, right now postiz has integration with dub.co for link shortening feature.
and we are trying to integrate short.io for the same purpose.

All I need to create a new file as short.io.ts that implements ShortLinking interface and implement all the methods from ShortLinking, so we can talk with short.io apis.

Finally, I need to import the new class inside ShortLinking service, so we can use it.

Let me know you thoughts and guide me if I am missing something and please assign this issue to me, as I have started in this issue.

@nevo-david
Copy link
Contributor Author

Yes, it's very simple :)
Just make sure you test it before, assigning it to you :)

@ak7550
Copy link

ak7550 commented Jan 19, 2025

sure, thanks :)

@ak7550
Copy link

ak7550 commented Jan 19, 2025

Hey @nevo-david , I was going through the docs of short.io and exploring the apis that will be needed for this integration.
What I found here is that we need to connect / create a domain with short.io, and all the short urls will be created under this domain.
Right now, I just created a free test domain for testing and integration purpose, but in the actual production environment, we need to setup or connect with an actual domain in short.io

What should be the value of this domain ?

PS. - api docs to connect with a domain

@ak7550 ak7550 linked a pull request Jan 19, 2025 that will close this issue
3 tasks
@nevo-david
Copy link
Contributor Author

@ak7550 I think we can use their short.io domain if we want, we don't have to use a customized one

@ak7550
Copy link

ak7550 commented Jan 19, 2025

Hi @nevo-david, quick update, I have implemented the necessary changes, that you can check the pr #564 .
All though, as per your suggestion, I am trying to test the code in local system. As the repo is configured via nx. I am having difficulties to run the backend server in debug mode in Vscode.

Would you like to share that how do you debug your code ? This is the first time I am working with nx, so it's a bit overwhelming for me to figure out the debug configuration for nx.

So this is the only thing due to which my progress is kind of blocked. I will keep on updating my work status in this thread.

@ak7550
Copy link

ak7550 commented Jan 21, 2025

Hey @nevo-david this feature is ready, please give a quick check and let me know if it needs any changes. #564

@egelhaus egelhaus linked a pull request Jan 30, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants