Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussing the API's format uniformity #26

Open
RockerFlower opened this issue Aug 31, 2022 · 1 comment
Open

Discussing the API's format uniformity #26

RockerFlower opened this issue Aug 31, 2022 · 1 comment

Comments

@RockerFlower
Copy link
Contributor

If a specific GitPOAP Event is not found when querying for it, for example,

https://public-api.gitpoap.io/v1/gitpoaps/1024/addresses

the result returned is:

{
    "message": "GitPOAP not found"
}

When scanning for all GitPOAPs held by an invalid address, for example,

https://public-api.gitpoap.io/v1/address/superphiz.eat/gitpoaps

the result returned is:

{
    "msg": "undefined is not a valid address"
}

I think two similar errors should be in the same format, with msg or message.

@mesquitaoliveira
Copy link

@RockerFlower I agree! They probably ended up passing 'msg' instead of 'message', or vice versa, by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants