-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TI Program - Add Extensions and Improve Statistics for TI Assembly Programs #6295
Comments
After some thought I feel like TI Program is mostly just assuming TI-BASIC, or at least TI z80 BASIC (There isn't extension support for other TI calc models currently), since (e)Z80 ASM/C aren't necessarily platform-specific. Technically, .8xp is a binary file anyway, so most source code (even for basic programs) isn't uploaded with a .8xp extension, but just a text file like here. Binary files aren't recognized as source, so unless you specifically create a text file with your code and then change the extension, it won't detect it. Given that assembly programs for TI calculators are often made with the extension Extensions for other TI calculator platforms which use some form of TI programming language could be nice to have, like |
I've created a grammar for z80 TI-BASIC here which could possibly help with syntax highlighting. What makes the most sense to me is to remove |
Hi @Alhadis & @scottmangiapane - previously you discussed about TI Programs and ASM in #3330 - I would like to hear some input on this as well on this before starting a PR. I definitely would like TI Programs to be accurately represented. :D |
Oh man, this is a blast from the past, both this repo and calculator programming in general. It's nice to see there's still an interest and community around it :)
I agree with this... IIRC I didn't realize Linguist couldn't recognize binary files when I first added the I know very little about assembly, so I can't speak to that, except that I agree marking all
I hesitate to rename "TI Program" to "TI-BASIC". Before the color TI-84s came out a lot of programs were made with axe parser, which is more powerful than TI-BASIC, compiles into assembly, and has its own syntax that's similar to but distinct from TI-BASIC. But it's been a long time since then, and from my googling it seems that Axe hasn't been updated in years, so perhaps it's no longer relevant. |
Searching here I see some repos using |
I agree with this as well. Initially when I suggested renaming it I wasn't thinking of third-party languages like AXE on monochromes and ICE on the colored calculators. While it isn't used much anymore (given that most students use color calculators now), it (along with ICE) still is widespread enough that I don't think renaming makes sense anymore. |
@scottmangiapane @TIny-Hacker I think a good approach to solution to also have is to maybe make TI Program a parent group and then split these into separate categories based on highlighting requirements much like how Typescript is implemented in languages.yml so we can solve the problem of statistics first without changing the current implementation. |
Describe the enhancement
There's missing extensions in linguist for TI Assembly which are part of TI Program.
It was brought to my attention by @TIny-Hacker that statistics for TI Programmers are widely skewed towards the most basic programs (with #5446 missing which exemplifies some basic programs in newer formats) such as while majority of the community uses TI Assembly but not all the extensions are included as there's no z80 assembly syntax highlighting for ".8xk" / ".8xk.txt" while ".83p" and ".83p.txt" are among the extensions for TI Assembly that are written in assembly are missing.
References:
https://en.wikibooks.org/wiki/TI_83_Plus_Assembly
https://github.com/github/linguist/blob/1345d0122a82119ae01abc366346fc9b022cc444/lib/linguist/languages.yml#L6675-L6685
Please see conversation reference at https://twitter.com/darkmastermindz/status/1626954142756356096
Requirements
I can help with contributing some initial PRs and testing as well if needed.
The text was updated successfully, but these errors were encountered: