Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add High Level Assembly language #5194

Closed
wants to merge 7 commits into from
Closed

Add High Level Assembly language #5194

wants to merge 7 commits into from

Conversation

Nixinova
Copy link
Contributor

@Nixinova Nixinova commented Feb 6, 2021

Closes #5169.

Usage seems to check out: search 'extension:hla' shows 12K files.

Sample under public domain.

Group under Assembly.

Syntax highlighter provided in #5169: https://github.com/Krebrov001/HLA-Projects/blob/master/hla.xml. Added as gitmodule.

@Nixinova Nixinova requested a review from a team as a code owner February 6, 2021 19:19
@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 6, 2021

Added the grammar but how do I get it to point to file hla.xml?

@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 6, 2021

What am I missing? "Fetch grammar submodules" test just throws Error: Process completed with exit code 1. with no explanation.

@lildude
Copy link
Member

lildude commented Feb 7, 2021

Scroll up and you'll find the error:

Error updating vendor/grammars/High Level Assembly
error: pathspec 'vendor/grammars/High Level Assembly' did not match any file(s) known to git

You need to add the grammar as a submodule.

@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 7, 2021

Did I not in 9c8aeb6?

@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 7, 2021

I have to register the submodules via the command line, don't I?..

@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 8, 2021

Lightshow throws Error parsing XML grammar: Unimplemented element; is that an issue?

@lildude
Copy link
Member

lildude commented Feb 8, 2021

I have to register the submodules via the command line, don't I?..

Yup. Thankfully this is pure git so you won't need to fight dependencies etc.

@lildude
Copy link
Member

lildude commented Feb 8, 2021

Lightshow throws Error parsing XML grammar: Unimplemented element; is that an issue?

Yes, with the grammar. That is not a TextMate-compatible grammar.

@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 9, 2021

That is not a TextMate-compatible grammar.

Okay, will revert then

Use the main Assembly grammar, nessphoro/sublimeassembly
@lildude
Copy link
Member

lildude commented Feb 9, 2021

Can you please state in the original note of this PR where the sample files came from and the license of each.

Despite there being more than >12k files, they're concentrated in surprisingly few repos:

Total files found: 12618
Unique public user/repos: 71
Unique owners: 64

@Krebrov001
Copy link

@lildude Here is another syntax highlighting grammar for HLA programming language, this time for vim text editor:
https://github.com/jmahler/hla.vim
Maybe it would work?

@Nixinova
Copy link
Contributor Author

I don't think thats in the right format for Linguist.

@lildude
Copy link
Member

lildude commented Feb 28, 2021

Yup, that won't work. The grammar needs to be a TextMate compatible grammar.

@Krebrov001
Copy link

@lildude I don't know what is a TextMate compatible grammar or how to create one. Can we have the language support without syntax highlighting for now, as far as the files are being recognized in the Languages section of a repository? Or maybe can you create a TextMate compatible grammar for me based on the Notepad++ or vim syntax highlighting files. I am yet unexperienced with such things.

@lildude
Copy link
Member

lildude commented Mar 1, 2021

Yes, we can add a language without a grammar. I'm not up to the task of creating a grammar, but maybe @Alhadis can.

That all said, there's no hurry as this language is still a looooong way from being popular enough for merging this PR.

@Nixinova
Copy link
Contributor Author

Closing for now as it'll be a while until usage is enough.

@Nixinova Nixinova closed this Mar 13, 2021
@Krebrov001
Copy link

So I see that I would have to find out how to implement a language grammar by myself, for adding support for the HLA programming language? Can anyone provide me some directions about how to do that?

@Nixinova
Copy link
Contributor Author

Create a tmLanguage grammar file to tokenise various aspects of the language. For example I have a few created at https://github.com/Nixinova/tmLanguage/tree/main/grammars.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High Level Assembly language is not recognized
3 participants