Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP call to http://YOUR_GITBUCKET/database/backup should be POST only #24

Open
aadrian opened this issue Apr 2, 2017 · 5 comments
Open

Comments

@aadrian
Copy link
Member

aadrian commented Apr 2, 2017

The HTTP call to http://YOUR_GITBUCKET/database/backup to create the backup should be POST only, not GET since the remote system is "changing".

Also it should really be secured for admins only, e.g. at least with a Token, so that it can be used with curl or wget.

Thank you.

@c0llab0rat0r
Copy link
Contributor

Each of these issues should be resolved now (using POST, requiring admin, and using api tokens as credentials).

@aadrian
Copy link
Member Author

aadrian commented Apr 19, 2021

@c0llab0rat0r This looks great, and also the detailed test suite too! Thank you.

@takezoe
Copy link
Contributor

takezoe commented Apr 20, 2021

It's already released. Can we close this?

@stevemesser
Copy link

I just update to the latest version of the H2 Backup plugin.

How can I redirect from with the plugin page to save the backup to /media/usb/backups in stead of the default location?

@stevemesser
Copy link

Never mind, I just tried a relative path and it worked fine, I could have sworn I tried that and that it didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants