Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package tests #8

Open
seabbs opened this issue Nov 6, 2019 · 4 comments
Open

Package tests #8

seabbs opened this issue Nov 6, 2019 · 4 comments

Comments

@seabbs
Copy link

seabbs commented Nov 6, 2019

It can really help users trust a package if it has robust testing, external validation and code reports. There are some great R packages (as I am sure you are aware) like {testthat} for unit testing code and {vdiffr} for testing plots.

Running tests externally (i.e with travis as set up here) can be really nice + a code coverage report can then be generated.

Very happy to help get this set up and start adding some tests!

Linked to #6

@giabaio
Copy link
Owner

giabaio commented Nov 7, 2019

Again --- I do think that BCEA is fairly robust, as it's been continuously tested and developed for quite some time now (I did start while I was working on one of my papers, back in 2007/8!). BUT, no reason why we shouldn't move towards more advanced & modern methods, so again --- happy to discuss!

@seabbs
Copy link
Author

seabbs commented Nov 12, 2019

I imagine it is! Do you have some unofficial testing framework in place? How do you currently check that changes don't introduce bugs/issues?

Unit testing is beneficial for development purposes (do new features break old features etc.) + shows that the package is following best practices and so can be quickly assessed for trustworthiness by users (not saying this is the only way but it is the standard).

Would you be happy for me to add the base testing and code coverage framework but a few outline tests? Adding full package tests may be a relatively big job and some tests will probably need your input as you know the package best.

If you were interested in a JOSS review (and passing community best practices etc) this would be required.

@giabaio
Copy link
Owner

giabaio commented Nov 12, 2019

I'm absolutely happy to move towards that and if you're willing to do so, happy for you to take the lead on the development version!

giabaio pushed a commit that referenced this issue Jul 21, 2020
Total rewrite of ceac.plot()
@n8thangreen
Copy link
Contributor

closed e.g. bfe87f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants