Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work to do on BCEA #18

Open
giabaio opened this issue Nov 8, 2019 · 2 comments
Open

Work to do on BCEA #18

giabaio opened this issue Nov 8, 2019 · 2 comments

Comments

@giabaio
Copy link
Owner

giabaio commented Nov 8, 2019

Here some ideas for (probably relatively minor) changes in the main code of BCEA and some of its functions to improve visualisation of the output (particularly the CEAC).
@seabbs --- something else to think about?

@seabbs
Copy link

seabbs commented Nov 12, 2019

geom_pointdensity might be a nice option to have. It also is very light dependency wise (https://github.com/LKremer/ggpointdensity/blob/master/DESCRIPTION) which is good.

Moving from pairwise to incremental also seems to make a lot of sense. Perhaps having a top level arugment to choose between the two (or a single funciton wrapper) would be a nice way to surface the option for the user?

@giabaio
Copy link
Owner Author

giabaio commented Nov 12, 2019

I think so. I think probably be a good idea to not completely modify the way in which the function works, but rather to add functionalities and let the user know about it... Again, I'm happy to be fairly informal and if you say you're happy/willing to take the lead on this, I'll certainly welcome requests for push and will acknowledge all the relevant work, of course! If you would rather I did things properly and set up collaborators, projects, streams, can also do --- but I need to get my head around that... ;-)

giabaio pushed a commit that referenced this issue Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants