From 37a3a5b7b1d40200d43dd94d337e85840808acd7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9on=20Kuchenbecker?= Date: Wed, 8 Nov 2023 13:35:23 +0000 Subject: [PATCH] Python manual fixes (mypy) --- src/ghga_datasteward_kit/s3_upload/config.py | 2 +- tests/fixtures/config.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ghga_datasteward_kit/s3_upload/config.py b/src/ghga_datasteward_kit/s3_upload/config.py index 253e8f2..19fd1fb 100644 --- a/src/ghga_datasteward_kit/s3_upload/config.py +++ b/src/ghga_datasteward_kit/s3_upload/config.py @@ -62,7 +62,7 @@ class LegacyConfig(BaseSettings): ), ) part_size: int = Field( - 16, description="Upload part size in MiB. Has to be between 5 and 5120." + default=16, description="Upload part size in MiB. Has to be between 5 and 5120." ) output_dir: Path = Field( ..., diff --git a/tests/fixtures/config.py b/tests/fixtures/config.py index 942488e..87272e7 100644 --- a/tests/fixtures/config.py +++ b/tests/fixtures/config.py @@ -16,6 +16,7 @@ """A config fixture""" from collections.abc import Generator +from pathlib import Path from tempfile import TemporaryDirectory import pytest @@ -34,7 +35,7 @@ def legacy_config_fixture() -> Generator[LegacyConfig, None, None]: s3_access_key_id=SecretStr("test_access_key"), s3_secret_access_key=SecretStr("test_secret_key"), bucket_id="test_bucket", - output_dir=output_dir, + output_dir=Path(output_dir), ) @@ -49,7 +50,7 @@ def config_fixture() -> Generator[Config, None, None]: s3_access_key_id=SecretStr("test_access_key"), s3_secret_access_key=SecretStr("test_secret_key"), bucket_id="test_bucket", - output_dir=output_dir, + output_dir=Path(output_dir), secret_ingest_pubkey=public_key, secret_ingest_baseurl="https://not-a-real-url", )