-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sails 0.12? #225
Comments
@mikedevita hey. Yes, I'm working on another project now. I will update generator with some fixes and Sails upgrade in few days. |
Hi @ghaiklor, after almost a year I tried to do that but tests fails. Could you give me some advices to solve issues ? I don't understand the stack trace |
@L1br3 do not update dependencies if you want to have working version. Otherwise, you need to migrate current codebase to new API of dependencies. |
I tried it with just updating sails to 0.12.4 and I've got exactly the same failures. |
I did a clean install from the generator and updated to 0.12.11. Then I adjusted the test bootstrap to use sails.load() instead of sails.lift() which is recommended by sails as the tests use sails.request() anyhow. That way the test/boostrap.js becomes this: "use strict";
const Sails = require('sails');
const config = require('../config/env/test');
before(done => {
Sails.load(config, (error) => {
if (error) return done(error);
done();
});
}); And everything works with sails 12 :) |
@BraunreutherA can you create a small PR, so I can publish a new version? :) |
PR is inbound for @BraunreutherA's proposed fixes i'm just testing the final parts now. |
Hey is there a plan to update this repo for sails 0.12 support?
The text was updated successfully, but these errors were encountered: