Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization backends dialog doesn't look nice when there are no truly available sync backends to add #837

Open
nekohayo opened this issue Mar 2, 2022 · 0 comments · May be fixed by #897
Labels
enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version

Comments

@nekohayo
Copy link
Member

nekohayo commented Mar 2, 2022

The default state of the "Synchronization" (backends) dialog looks like this:

Screenshot from 2022-03-02 12-35-19

First, the "Local File" backend's label and button are totally wrong there. It's not a synchronization service, it's the default file storage backend, so the label should reflect that, and the "Disable syncing" button should be hidden rather than disabled in that case.

If you want the UI to be more helpful, the label could instead explain where the currently used XML data file is located on the filesystem, and a button (or hyperlink?) to xdg-open (or whatever is the proper way in the flatpak portal-enabled world these days) the file browser to its containing location.

Then, if you don't have "python-caldav" installed/available (as is the case on Fedora, for example), if you click the "+" button you get this UI:

Screenshot from 2022-03-02 12-35-22

That combobox is totally useless when it has zero items in it, and so are the labels and buttons shown there. Instead, it would make much more sense to at least show a human-readable explanation that details which dependencies are missing to allow which backends to be available (but then there's also the question of what to do when only some of the backends are unavailable instead of all of them, if we have more than one sync backend in the future).

@nekohayo nekohayo added enhancement priority:low low-hanging-fruit "Easy picks" suitable for new contributors to tackle reproducible-in-git Issues that affect the current dev version labels Mar 2, 2022
@runkaiz runkaiz linked a pull request May 15, 2022 that will close this issue
@nekohayo nekohayo linked a pull request Feb 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant