Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neutral commit statuses treated as failures #15

Open
assimovt opened this issue Jun 16, 2020 · 0 comments
Open

Neutral commit statuses treated as failures #15

assimovt opened this issue Jun 16, 2020 · 0 comments
Assignees
@assimovt
Labels
bug Something isn't working

Comments

@assimovt
Copy link
Member

Seems like GitHub API (https://developer.github.com/v3/repos/deployments/#failed-commit-status-checks) treats “neutral” as a failure and hence raises a 409 Conflict error which SlashDeploy bubbles up. Neutral status runs should be ok for deploys.
@assimovt assimovt added the bug Something isn't working label Jun 16, 2020
@assimovt assimovt self-assigned this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assimovt assimovt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@assimovt