Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only send debug images referenced in the stacktrace for events #1755

Open
1 task
Tracked by #158
buenaflor opened this issue Nov 23, 2023 · 2 comments · May be fixed by #2329
Open
1 task
Tracked by #158

Only send debug images referenced in the stacktrace for events #1755

buenaflor opened this issue Nov 23, 2023 · 2 comments · May be fixed by #2329
Assignees
@martinhaintz
Labels
Platform: Dart

Comments

@buenaflor
Copy link
Contributor

buenaflor commented Nov 23, 2023 •
edited
Loading

Description

Ref: getsentry/team-mobile#158

Blocked by
Beta Give feedback
@buenaflor buenaflor mentioned this issue Nov 23, 2023
Open
@buenaflor buenaflor self-assigned this Dec 7, 2023
@buenaflor
Copy link
Contributor Author

buenaflor commented Dec 13, 2023 •
edited
Loading

Can be implemented for cocoa debug images similar to how react native does it which requires the instruction addresses to be passed to the cocoa flutter plugin. Relevant code part for Flutter is here

@buenaflor buenaflor changed the title Only send debug images referenced in the stacktrace Only send debug images referenced in the stacktrace for events Dec 13, 2023
@buenaflor buenaflor removed their assignment Dec 21, 2023
@buenaflor buenaflor mentioned this issue Jan 15, 2024
Open
@martinhaintz martinhaintz linked a pull request Oct 7, 2024 that will close this issue
Open
6 tasks
@philipphofmann
Copy link
Member

philipphofmann commented Oct 14, 2024 •
edited
Loading

@buenaflor replace getDebugImagesForAddresses with either SentryDebugImageProvider.getDebugImagesFromCacheForFrames or SentryDebugImageProvider.getDebugImagesFromCacheForThreads added in getsentry/sentry-cocoa#4435, which will ship with Cocoa 8.39.0. getDebugImagesForAddresses is slow and caused AppHangs on iOS; see getsentry/sentry-cocoa#4399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinhaintz martinhaintz

Labels
Platform: Dart
Projects
Mobile & Cross Platform SDK
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/only send debug images referenced in the stacktrace for events getsentry/sentry-dart
3 participants
@philipphofmann @buenaflor @martinhaintz