Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry-cli should fail if it cannot upload a debug symbol due to max size #3536

Open
zsd4yr opened this issue Jan 15, 2025 · 2 comments
Open

Comments

@zsd4yr
Copy link

zsd4yr commented Jan 15, 2025

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

Related to #1569 and getsentry/sentry#36538

1、Use sentry-cli upload a pdb file , size more then 2G
2、The pdb file upload success but was not successful

sentry-cli.exe --url <redacted> upload-dif -t pdb -t pe .\RelWithDebInfo\<redacted>.pdb --org <redacted> --project <redacted> --log-level trace --wait --auth-token '<redacted>'
...
  DEBUG   2025-01-15 23:20:49.504213100 +00:00 searching location .\RelWithDebInfo\<redacted>.pdb
  DEBUG   2025-01-15 23:20:49.505496500 +00:00 trying to process <redacted>.pdb
  DEBUG   2025-01-15 23:20:49.506327 +00:00 trying to parse dif <redacted>.pdb
  WARN    2025-01-15 23:20:49.999061500 +00:00 Skipping debug file since it exceeds 2.00GB: <redacted>.pdb (2.02GB)
  DEBUG   2025-01-15 23:20:49.999548100 +00:00 skipping <redacted>.pdb because of size
  DEBUG   2025-01-15 23:20:50.085047 +00:00 finished location .\RelWithDebInfo
> Found 0 debug information files
> No debug information files found
PS > $LASTEXITCODE
0

Expected Result

If sentry-cli cannot complete the requested work, it should return non-zero

Actual Result

sentry-cli silently fails from the perspective of the exit code

Product Area

APIs

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link

getsantry bot commented Jan 15, 2025

Assigning to @getsentry/support for routing ⏲️

@zsd4yr
Copy link
Author

zsd4yr commented Jan 15, 2025

The issue is even worse when you upload using a directory instead of the full path to the pdb -- the trace level output doesn't even list that it considered the pdb

@dalnoki dalnoki transferred this issue from getsentry/sentry Jan 16, 2025
@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Status: No status
Development

No branches or pull requests

1 participant