-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
porter bundle publish command #254
Comments
Do we need a separate issue to track removing the invocation image push step from |
If we remove it, without making any other change, will stuff still work? Or do we need do it as part of publish at the same time to not break porter? |
If we remove it without making any other change, local bundle installation will continue to work (assuming using same docker daemon as image was built with) but the bundle may not be installable by another user on a different machine (unless I would think adding it as part of publish in this/same set of commits would make the most sense, to cover the latter case mentioned above. It feels 'right' that the invocation image would/should only be pushed to a remote repo when the bundle is published. |
Ok, sounds good to me to do it all in a single PR then. |
CLOSED BY OTHER PRS |
We need a new command
porter bundle publish
, aliasporter publish
that uses cnabio/duffle#681 to push a bundle to a docker registry.Tag
.We aren't using the
push
verb because it's a composite command doing multiple bits of work under the hood:The text was updated successfully, but these errors were encountered: