Form attachment hash for empty datasets is surprising and/or documented incorrectly

[alxndrsn]

1. docs and code do not match
2. inconsistent date formats are used

docs vs code

1970-01-01 vs 1970-01-01 00:00:00

docs

central-backend/docs/api.yaml

Line 192 in 9e177f0

* In the [OpenRosa Form Manifest](/central-api-form-management/#openrosa-form-manifest-api), if a Form Attachment is linked to a Dataset then the value of `hash` is the MD5 of the last updated timestamp or the MD5 of `1970-01-01 00:00:00` if the Dataset is empty.

code

central-backend/lib/model/query/form-attachments.js

Line 157 in 9e177f0

return attachment.with({ openRosaHash: md5sum(lastTimestamp ? lastTimestamp.toISOString() : '1970-01-01') });

inconsistent date formats

central-backend/lib/model/query/form-attachments.js

Line 157 in 9e177f0

return attachment.with({ openRosaHash: md5sum(lastTimestamp ? lastTimestamp.toISOString() : '1970-01-01') });

• format 1970-01-01T00:00:00.000Z if lastTimestamp is truthy
• format 1970-01-01 if lastTimestamp is falsy