feat: Instrument calls to libraries #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dividedmind
reviewed
Mar 16, 2024
There was a problem hiding this comment.
I think you're on the right track. Couple of comments:
- Will this work for ESM? I'm worried the whole approach will need to be different. Unless we can use the same trick for CJS-loading and hoping the hooked module will be cached across the two loaders...
- The Error approach is a no-go; it will have an unacceptably massive performance hit. Also, it's maybe a bit too complicated; appmap-ruby skips tracing
if current_package.shallow? && last_package == current_package(where package is just an appmap.yml package: entry), which is extremely simple and works well in practice. This also allows shallow mode to work for user (eg. path:) packages, a feature occasionally useful.
src/hooks/standardLibs.ts
Outdated
| @@ -0,0 +1,152 @@ | |||
| import assert from "node:assert"; | |||
|
|
|||
| import { ESTree } from "meriyah"; | |||
There was a problem hiding this comment.
Please try to use import type when applicable to make it clear when code is being imported vs. just types.
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
from
5f31df6
to
7d321a0
Compare
BTW, I think if ESM support is going to be non-trivial it's ok to just do this for CJS for now and open a separate issue to add ESM support later. |
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
6 times, most recently
from
b3e4888
to
970d733
Compare
It was trivial for built-ins. For third party libs I managed to do it by implementing |
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
from
46de9c8
to
988deeb
Compare
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
from
988deeb
to
6132680
Compare
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
2 times, most recently
from
1c5375a
to
b13d2e4
Compare
dividedmind
requested changes
Apr 22, 2024
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
5 times, most recently
from
6a1f9e5
to
153af06
Compare
dividedmind
approved these changes
Apr 24, 2024
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
from
153af06
to
efa6a7b
Compare
zermelo-wisen
force-pushed
the
feat/instrument-calls-to-libraries
branch
from
efa6a7b
to
a8b9fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83