Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you studied the threshold signature of currency neo and can it be applied to this alice? #259

Open
CodeLion66 opened this issue May 10, 2023 · 3 comments
Assignees

Comments

@CodeLion66
Copy link

          First of all, thank you for your reply amidst your busy schedule

We have been using Alice for three years and it is indeed a great open source project.
Thank you very much if you can support more curves. If so, can we support Neo's threshold signature?
thanks !!!

Originally posted by @CodeLion66 in #252 (comment)

@cychuang0924
Copy link
Contributor

Hi CodeLion66,

If my understanding is correct, Neo's threshold signature refers to the replacement of curve from secp256k1 to p256.

If yes, then this version should support Neo's threshold signature.

You just need to replace the elliptic curve curve with p256 in GG18 or CGGMP.

For example:

curve = elliptic.Secp256k1()

Replace secp256k1 to p256.

If you have any questions, please let me know. Thanks a lot.

@cychuang0924 cychuang0924 self-assigned this May 11, 2023
@CodeLion66
Copy link
Author

HI, @cychuang0924
Yes, using p256 for the final tx signature should be fine, but it seems that Neo used a private key when building the account object, so I'm not sure if it's mandatory. Although this may not be related to Alice, if you know, you can let me know.
image

@cychuang0924
Copy link
Contributor

cychuang0924 commented Dec 5, 2023

Hi, @CodeLion66

Sorry to be replying you so late.

If creating account must involve a private key, then you can combine the private key from shares to obtain this requirement.
But, you can check that if it is actually possible to generate an address using just the public key. If it is, then you can write a new function with the input "public key". Since in most cases, the account address is generated by the public key.

Sincerely,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants