Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Typings #573

Open
KaiVolland opened this issue May 16, 2023 · 0 comments
Open

Improve Typings #573

KaiVolland opened this issue May 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@KaiVolland
Copy link
Contributor

Currently there are some minor issue with the types of the geostyler-style. We should check if we can improve these types without breaking changes.

  1. GeoStylerFunction is a union type of all functions. This leads to issues with the (currently two) functions that don't have args. In particular TypesScript says that a GeoStylerFunction has no property args unless you exclude the functions without args. We should avoid adding an empty array as args but find a TypeScript way for this.

  2. PropertyType includes unknown. This translates to PropertyType = unknown which is obviously not perfect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
CodeSprint 2024
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KaiVolland @jansule