Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize layers/groups management in TOC #10247

Open
2 of 6 tasks
tdipisa opened this issue Apr 23, 2024 · 1 comment · May be fixed by #10609
Open
2 of 6 tasks

Normalize layers/groups management in TOC #10247

tdipisa opened this issue Apr 23, 2024 · 1 comment · May be fixed by #10609
Assignees
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Apr 23, 2024

Description

To maintain retro-compatibility with old maps, as reported here in #10246, with the new TOC there are still a few inconsistent but not blocking behaviors due to how the 'default group' is managed.

Loading a Map in one of the following scenarios:

  • Importing a Map
  • Opening an existing Map

a logic should intervene to automatically update the TOC internal structure to definitely fix retro-compatibility issues.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

For example, below are some use cases to be fixed within this issue:

1

  1. Open this map (export here for testers)
  2. The first group (with name "New York") is not draggable but it should be

2

  1. Open this map (export here for testers)
  2. Add a new layer from related TOC toolbar button ensuring no groups are selected
  3. The layer is added inside the first group instead as a first item/leaf in the TOC

3

  1. Open this map (export here for testers)
  2. Open the one group (e.g. the "Florence" one) and drag a layer outside of any group
  3. It is not possible in this old map (where the concept of "default group" is still present at TOC state level) to have layers outside a group

As part of this issue is definitely requested to provide also the necessary clean up for completely removing the concept of "default group" to make also old maps consistent with new TOC behaviors.

@tdipisa tdipisa added this to the 2024.01.01 milestone Apr 23, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 24, 2024
@tdipisa tdipisa modified the milestones: 2024.01.01, 2024.01.02 May 20, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned allyoucanmap Jun 7, 2024
@tdipisa tdipisa modified the milestones: 2024.01.02, 2024.02.00 Jul 2, 2024
@mahmoudadel54
Copy link
Contributor

What I understood from the description, for some old maps, it is requested to handle the logic of adding layer without group in case not selecting any existing group on TOC before adding. is it correct ?

The current implemented code is Ok with any new created map based on this PR: #10278, right ?

@tdipisa tdipisa modified the milestones: 2024.02.00, 2024.02.01 Aug 28, 2024
@tdipisa tdipisa assigned rowheat02 and unassigned mahmoudadel54 Oct 4, 2024
@rowheat02 rowheat02 linked a pull request Oct 10, 2024 that will close this issue
12 tasks
@tdipisa tdipisa modified the milestones: 2024.02.01, 2024.02.02 Nov 4, 2024
@tdipisa tdipisa modified the milestones: 2024.02.02, 2025.01.00 Dec 2, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants