Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate parsing of CQL to pygeofilter in a more unified way #1557

Open
ricardogsilva opened this issue Feb 27, 2024 · 2 comments
Open

Delegate parsing of CQL to pygeofilter in a more unified way #1557

ricardogsilva opened this issue Feb 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ricardogsilva
Copy link
Member

The current parsing of CQL follows different code paths depending on the request, for example:

  • for GET requests, we use the pygeofilter ecql parser
  • for POST requests, in the postgresql provider we use pygeofilter's cql_json parser
  • for POST requests, in the elastic provider we use a custom parsing strategy that involves pydantic and other logic

Given that pygeofilter now has support for elastic as a backend and also supports both ecql and cql_json we can try to unify the CQL parsing and possibly even remove the pydantic and custom logic bits. We'd rely on pygeofilter for filtering CQL in a more unified way.

Copy link

github-actions bot commented Jun 2, 2024

This Issue has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Jun 2, 2024
Copy link

As per RFC4, this Issue has been closed due to there being no activity for more than 90 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
@tomkralidis tomkralidis reopened this Dec 23, 2024
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Dec 23, 2024
@github-actions github-actions bot removed the stale Issue marked stale by stale-bot label Dec 29, 2024
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Dec 30, 2024
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Dec 31, 2024
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Jan 6, 2025
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Jan 14, 2025
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants