Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate versions of MTPlotTools.py #5

Open
ghost opened this issue Oct 9, 2012 · 2 comments
Open

Duplicate versions of MTPlotTools.py #5

ghost opened this issue Oct 9, 2012 · 2 comments
Assignees

Comments

@ghost
Copy link

ghost commented Oct 9, 2012

There are two versions of MTPlotTools.py -- one in core and the other in imaging.

One needs to be deleted, but I'm not sure what code is duplicated over both, and whether other modules refer to one or other or both. Jared?

@ghost ghost assigned kujaku11 Oct 9, 2012
@geophysics
Copy link
Owner

I'd prefer to have the modules/functions that are generating visual output in a different folder than the purely 'theoretical' ones. Maybe, we can rename 'imaging', if you can come up with something better/more intuitive?

@ghost
Copy link
Author

ghost commented Oct 10, 2012

I agree in principle but remember we can do this in a purely cosmetic way, for example with a file at MTpy/plots.py containing:

__all__ = ['plot_something', 'plot_something_else', 'another_plot_function']

from MTpy.core.MTPlotTools import plot_something
from MTpy.imaging.ptplots import plot_something_else
from MTpy.modelling.SomeNewModule import another_plot_function

and then people can:

>>> import MTpy.plots
>>> MTpy.plots.plot_something()
>>> MTpy.plots.plot_something_else()
>>> MTpy.plots.another_plot_function()

After all sometimes plotting code is intimiately related to the processing/modelling/'theoretical' code, and having it so far apart is not the way modules and subpackages should be organized.

@ghost ghost mentioned this issue Oct 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants