Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of type concept field is inconsistent #2

Open
strogonoff opened this issue Oct 29, 2019 · 3 comments
Open

Value of type concept field is inconsistent #2

strogonoff opened this issue Oct 29, 2019 · 3 comments

Comments

@strogonoff
Copy link
Contributor

strogonoff commented Oct 29, 2019

This concept has type:

---
term: Cartography
termid: 32
eng:
id: 32
term: Cartography
definition: Set of operations and processes that take part in the creation, edition
and analysis of maps.
language_code: eng
notes: []
examples: []
type: term
comments:
- TMG_NP

This concept doesn’t have type:

term: EASIG
termid: 105
eng:
id: 105
term: EASIG
definition: Enterprise Architecture Special Interest Group
language_code: eng
notes: []
examples: []
authoritative_source:
link: 'https://www.opengeospatial.org/acronyms'

Method definition: https://github.com/geolexica/osgeo-termbase/blob/565819ab9c2ba4408cc442f623a6a3c1039102a5/lib/osgeo/termbase/term.rb#L172-L177

@strogonoff strogonoff transferred this issue from geolexica/osgeo-termbase Oct 30, 2019
@strogonoff
Copy link
Contributor Author

cc’ing @ronaldtse though I guess it’s just a symptom of early stage data gathering

@ronaldtse
Copy link
Member

Indeed, this is due to early data gathering. Concept 105 is type: abbrev because it's an abbreviation.

@skalee
Copy link
Contributor

skalee commented Jan 19, 2021

I suppose this is outdated and we should close it. Objections, @strogonoff, @ronaldtse?

Grepping with grep -e 'type:' -r osgeo-glossary/concepts --no-filename | uniq gives only: type: expression.


Abbreviations are handled in a different way now (abbrev: true), full example below. If this is incorrect for Glossarist, please say a word @strogonoff.

term: 3-D Elevation Program
termid: 1
eng:
  id: 1
  language_code: eng
  notes: []
  examples: []
  authoritative_source:
    link: https://www.osgeo.org/initiatives/geo-for-all/geo-newsletters-archive/
  terms:
  - type: expression
    designation: 3-D Elevation Program
    normative_status: preferred
  - type: expression
    designation: 3DEP
    normative_status: preferred
    abbrev: true

@skalee skalee closed this as completed Jan 19, 2021
@skalee skalee reopened this Jan 19, 2021
@ronaldtse ronaldtse moved this to 🆕 New in Geolexica Jul 24, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 📋 Backlog in Geolexica Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants